On Fri, 23 May 2025 21:20:39 GMT, Johannes Bechberger <jbechber...@openjdk.org> wrote:
>> This is the code for the [JEP 509: CPU Time based profiling for >> JFR](https://openjdk.org/jeps/509). >> >> Currently tested using [this test >> suite](https://github.com/parttimenerd/basic-profiler-tests). This runs >> profiles the [Renaissance](https://renaissance.dev/) benchmark with >> - ... different heap sizes >> - ... different GCs >> - ... different samplers (the standard JFR and the new CPU Time Sampler and >> both) >> - ... different JFR recording durations >> - ... different chunk-sizes > > Johannes Bechberger has updated the pull request incrementally with one > additional commit since the last revision: > > Fix compilation src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 601: > 599: > 600: if (jt->thread_state() == _thread_in_native && > 601: tl->cpu_time_jfr_queue().size() > > tl->cpu_time_jfr_queue().capacity() * 2 / 3) { Is this testing what you intend? The precedence order is [*, / ], from left to right associativity ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2106311361
