On Fri, 23 May 2025 21:20:39 GMT, Johannes Bechberger <jbechber...@openjdk.org> 
wrote:

>> This is the code for the [JEP 509: CPU Time based profiling for 
>> JFR](https://openjdk.org/jeps/509).
>> 
>> Currently tested using [this test 
>> suite](https://github.com/parttimenerd/basic-profiler-tests). This runs 
>> profiles the [Renaissance](https://renaissance.dev/) benchmark with
>> - ... different heap sizes
>> - ... different GCs
>> - ... different samplers (the standard JFR and the new CPU Time Sampler and 
>> both)
>> - ... different JFR recording durations
>> - ... different chunk-sizes
>
> Johannes Bechberger has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fix compilation

src/hotspot/share/jfr/periodic/sampling/jfrThreadSampling.cpp line 374:

> 372:       JfrCPUTimeThreadSampling::send_lost_event( now, 
> JfrThreadLocal::thread_id(jt), queue.get_and_reset_lost_samples());
> 373:     }
> 374:     queue.clear();

queue.clear() is the same operation as queue.set_size(0) on line 368.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2106312208

Reply via email to