On Wed, 14 May 2025 03:45:17 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed PrintAOTLogsAsCDSLogs and improved comments > > src/hotspot/share/cds/aotLogging.hpp line 63: > >> 61: // The messages printed with the log_aot_xxx() macros work as if they are >> 62: // using the [cds] tag when running with the "classic" CDS flags such as >> 63: // -XX:SharedArchiveFile: > > What if you specify no flags and rely on the implicit settings e.g. > `-Xshare:auto`, will `-Xlog:cds` continue to work as today? I updated the comments to flip the condition -- if no `-XX:AOTxxx` flag are used, we print the `[cds]` decorations. The new AOT workflow requires the use of at least one flag that starts with `-XX:AOT`. There's no implicit use of AOT features. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25136#discussion_r2089355725
