On Tue, 13 May 2025 08:32:09 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> More conversion; clean up; bug fixes > > src/hotspot/share/cds/aotLogging.hpp line 77: > >> 75: // - These logs can be selected ONLY with -Xlog:aot. They are always >> printed with [aot] decoration >> 76: // >> 77: // [2] When using CDS archives, and PrintAOTLogsAsCDSLogs=true > > I guess I am missing some basic knowledge about AOT here. If we are using > legacy CDS not AOT, then why would there be any AOT log statements ??? I got rid of the `PrintAOTLogsAsCDSLogs` option. I thought maybe it could make the transition easier for some users but it's probably an overkill. I've updated aotLogging.hpp to describe the deprecation process. I tried to model it after the deprecation process for VM options. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25136#discussion_r2087860290
