On Wed, 14 May 2025 01:07:36 GMT, Ioi Lam <ik...@openjdk.org> wrote: >> This is an alternative (and opposite) approach to >> https://github.com/openjdk/jdk/pull/24895. We basically convert most `[cds]` >> logs to `[aot]` logs. However, for the few logs that might be needed by >> existing user scripts, we use macros like `aot_log_info`, `aot_log_debug` so >> that they can be selected/printed using the `[cds]` tag. >> >> We have a few hundred logs that start with `[cds]`. To aid reviewing, this >> PR will convert only part of them. I will create a second PR that coverts >> the rest of the logs. >> >> Please see **aotLogging.hpp** for how the macros work. > > Ioi Lam has updated the pull request incrementally with one additional commit > since the last revision: > > Removed PrintAOTLogsAsCDSLogs and improved comments
src/hotspot/share/cds/aotLogging.hpp line 87: > 85: // =================== > 86: // > 87: // This is model after the deprecate/obsolete/removal process of VM > options in arguments.cpp Suggestion: // This is modeled after the deprecate/obsolete/expire process of VM options in arguments.cpp src/hotspot/share/cds/aotLogging.hpp line 92: > 90: // the CDS Compatibility Logs must be selected with -Xlog:cds > 91: // > 92: // JDK 26 - Same as above, except that when -Xlog:cds is specified in the > command-line, an warning Suggestion: // JDK 26 - Same as above, except that when -Xlog:cds is specified in the command-line, a warning src/hotspot/share/cds/aotLogging.hpp line 98: > 96: // the CDS Compatibility Logs must be selected with -Xlog:aot. > 97: // > 98: // When -Xlog:cds is specified in the command-line, an warning > message is printed to Suggestion: // When -Xlog:cds is specified in the command-line, a warning message is printed to ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25136#discussion_r2087966346 PR Review Comment: https://git.openjdk.org/jdk/pull/25136#discussion_r2087966639 PR Review Comment: https://git.openjdk.org/jdk/pull/25136#discussion_r2087966847
