On Thu, 17 Oct 2024 23:14:50 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> no need in raw monitor - removed > > test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStressTest/libNotifyFramePopStressTest.cpp > line 66: > >> 64: char* name = nullptr; >> 65: >> 66: pop_count++; > > I think there is still a concern that once this increment is done, the next > iteration in control() can start. It will try to suspend this thread, which I > think can happen in the 3 JVMTI calls below, and controll() will then call > NotifyFramePop(), which will clobber last_notify_method. I think just moving > this increment to the end will resolve that issue, or at least move it to > after the last_notify_method reference. I agree, it is more safe to move the increment to the end. Moved now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1805583958
