On Sat, 7 Sep 2024 01:04:14 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with two 
>> additional commits since the last revision:
>> 
>>  - Update test/hotspot/jtreg/serviceability/sa/libupcall.c
>>    
>>    Co-authored-by: Jorn Vernee <jornver...@users.noreply.github.com>
>>  - Update 
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/ppc64/PPC64Frame.java
>>    
>>    Co-authored-by: Jorn Vernee <jornver...@users.noreply.github.com>
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/UpcallStub.java line 
> 41:
> 
>> 39: 
>> 40:   private static AddressField lastJavaSPField;
>> 41: 
> 
> I think it's better without the blank lines.

Removed them in new commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20885#discussion_r1747859951

Reply via email to