On Tue, 27 Aug 2024 23:02:57 GMT, Alex Menkov <[email protected]> wrote:
>> test/hotspot/jtreg/serviceability/jvmti/HiddenClass/libHiddenClassSigTest.cpp
>> line 333:
>>
>>> 331: }
>>> 332:
>>> 333: err = jvmti->CreateRawMonitor("Event Monitor", &event_mon);
>>
>> Sorry, forgot to mention.
>> There is a function ' create_raw_monitor(jvmti, name)" in jvmti commo that
>> saves a few more lines:
>> use
>> event_mon = create_raw_monitor(jvmti, "Event Montori");
>
> I saw the function, but don't see much sense in it.
> On error it just return null (so need to check result anyway) and it's not
> possible to get jvmti error
Strange, this function should be improved to at least log the probleml.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20699#discussion_r1733632140
