On Sat, 24 Aug 2024 01:22:55 GMT, Leonid Mesnik <[email protected]> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use RawMonitorLocker from jvmti_common
>
> test/hotspot/jtreg/serviceability/jvmti/HiddenClass/libHiddenClassSigTest.cpp
> line 54:
>
>> 52: }
>> 53:
>> 54: struct MonitorLock {
>
> jvmti.common has RawMonitorLocker
> (and LOG)
> could they be used in test?
> or even better to just use
> std::atomic<bool>
> if it is enough.
> The atomic are not used in hotspot but no limitation about using them in test
> code.
Good point, updated to RawMonitorLocker.
I left LOG0/LOG1/LOG2 as is to avoid a lot of changes in the test
std::atomic<bool> is not enough in the case.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20699#discussion_r1731989017
