On Sat, 24 Aug 2024 00:51:54 GMT, Alex Menkov <amen...@openjdk.org> wrote:
> The fix adds guards against JVMTI_ERROR_WRONG_PHASE error in event handlers
>
> Testing: hotspot/jtreg/serviceability/jvmti on all platforms
Changes requested by lmesnik (Reviewer).
test/hotspot/jtreg/serviceability/jvmti/HiddenClass/libHiddenClassSigTest.cpp
line 54:
> 52: }
> 53:
> 54: struct MonitorLock {
jvmti.common has RawMonitorLocker
(and LOG)
could they be used in test?
or even better to just use
std::atomic<bool>
if it is enough.
The atomic are not used in hotspot but no limitation about using them in test
code.
-------------
PR Review: https://git.openjdk.org/jdk/pull/20699#pullrequestreview-2258280922
PR Review Comment: https://git.openjdk.org/jdk/pull/20699#discussion_r1729646507
