On Tue, 30 Jul 2024 05:18:17 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> Ashutosh Mehra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments by Thomas S.
>>
>> Signed-off-by: Ashutosh Mehra <asme...@redhat.com>
>
> src/hotspot/share/compiler/compilationMemoryStatistic.hpp line 40:
>
>> 38:
>> 39: // Helper class to wrap the array of arena tags for easier processing
>> 40: class ArenaTagsCounter {
>
> Sorry for being a stickler for precise names, but I would like plural for
> counters here - it is not a single counter, its a series/vector/array of
> counters.
> Any of these work for me: ArenaCountersByTag - ArenaCountersByTagVector -
> ArenaTagCounterVector - ArenaTagCounters
I am pretty bad in naming things, so I welcome these suggestions. I will go
with ArenaCountersByTag.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20304#discussion_r1696973723
