On Mon, 29 Jul 2024 14:49:48 GMT, Ashutosh Mehra <asme...@openjdk.org> wrote:
>> Some minor improvements to CompilationMemoryStatistic. More details are in >> [JDK-8337031](https://bugs.openjdk.org/browse/JDK-8337031) >> >> Testing: >> test/hotspot/jtreg/compiler/print/CompileCommandPrintMemStat.java >> >> test/hotspot/jtreg/serviceability/dcmd/compiler/CompilerMemoryStatisticTest.java > > Ashutosh Mehra has updated the pull request incrementally with one additional > commit since the last revision: > > Address review comments by Thomas S. > > Signed-off-by: Ashutosh Mehra <asme...@redhat.com> Minor naming nit, otherwise good. src/hotspot/share/compiler/compilationMemoryStatistic.hpp line 40: > 38: > 39: // Helper class to wrap the array of arena tags for easier processing > 40: class ArenaTagsCounter { Sorry for being a stickler for precise names, but I would like plural for counters here - it is not a single counter, its a series/vector/array of counters. Any of these work for me: ArenaCountersByTag - ArenaCountersByTagVector - ArenaTagCounterVector - ArenaTagCounters ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/20304#pullrequestreview-2206660184 PR Review Comment: https://git.openjdk.org/jdk/pull/20304#discussion_r1696322176
