On Wed, 24 Jul 2024 10:45:05 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:

>> Some minor improvements to CompilationMemoryStatistic. More details are in 
>> [JDK-8337031](https://bugs.openjdk.org/browse/JDK-8337031)
>> 
>> Testing:
>>   test/hotspot/jtreg/compiler/print/CompileCommandPrintMemStat.java
>>   
>> test/hotspot/jtreg/serviceability/dcmd/compiler/CompilerMemoryStatisticTest.java
>
> I plan to look at this later this week.

@tstuefe I have added a patch to address your review comments.

> or just write a small wrapper class holding a size_t vector and taking care 
> of the copying.

Using a wrapper class is a good idea. I have added `ArenaTagsCounter` for that.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20304#issuecomment-2256315773

Reply via email to