On Mon, 29 Jul 2024 11:30:08 GMT, Jiawei Tang <jwt...@openjdk.org> wrote:
>> I add the testcase which can reproduce the crash. I hope that I could get >> some advise if the codes need changing. > > Jiawei Tang has updated the pull request incrementally with one additional > commit since the last revision: > > changes according to reviewers' advice Could you please, do some test renaming/refactoring? We have a number of `.c` JVMTI agents in the testbase. The plan is to convert them to `.cpp` in the future. Can you convert the test use .cpp as well? Also, I'm suggesting to name test directory/files as below: - TestPinCaseWithCFLH/TestPinCaseWithCFLH.java - TestPinCaseWithCFLH/libTestPinCaseWithCFLH.cpp ------------- PR Comment: https://git.openjdk.org/jdk/pull/20373#issuecomment-2257149690
