On Mon, 29 Jul 2024 10:01:56 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Jiawei Tang has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new commit since the last revision: >> >> 8337331: crash: pinned virtual thread will lead to jvm crash when running >> with the javaagent option > > test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTraceWithAgent/TestPinCaseWithTrace.java > line 36: > >> 34: * @run main/othervm/timeout=100 -Djdk.tracePinnedThreads=full >> TestPinCaseWithTrace >> 35: * @run main/othervm/timeout=100 -javaagent:TestPinCaseWithTrace.jar >> TestPinCaseWithTrace >> 36: * @run main/othervm/timeout=100 -Djdk.tracePinnedThreads=full >> -javaagent:TestPinCaseWithTrace.jar TestPinCaseWithTrace > > Unclear why we need the three variants. > > Also where does the timeout value come from? How long does the test take to > run? I will remove the first two variants. The task will not end because of dead lock in vm. But if the issue is fixed, it can finish in 1s. Considering the differences in platforms and jdk mode(release/debug), I extended the time limit. I'm not sure if I should set this timeout value. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20373#discussion_r1695042090
