On Mon, 20 May 2024 13:19:37 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:

>> Doing that makes git think it's a new file, rather than a rename.
>> I was doing this in 
>> [a26ee08](https://github.com/openjdk/jdk/commit/a26ee085b5184d62a879f88f6cca6780e0e4e472)
>>  and removed it
>
> LGTM - there are further potential improvements that could be made in this 
> file - like replacing `<code></code>` with `{@code }` and `<pre></pre>` with 
> `{@snippet }` but I guess that can wait until someone has the inclination and 
> bandwidth to do it...

Fixed, found how to "lazily" append to the lines I want so adding the " *" 
wasn't an issue

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19263#discussion_r1607108275

Reply via email to