On Sun, 19 May 2024 19:05:19 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
>> src/java.management.rmi/share/classes/javax/management/remote/rmi/package-info.java >> line 26: >> >>> 24: */ >>> 25: >>> 26: /** >> >> I assume you'll need to prepend each line with `*` too, which has the side >> effect of making it appear that every line is changed but I think we just >> need to get over that. > > Doing that makes git think it's a new file, rather than a rename. > I was doing this in > [a26ee08](https://github.com/openjdk/jdk/commit/a26ee085b5184d62a879f88f6cca6780e0e4e472) > and removed it LGTM - there are further potential improvements that could be made in this file - like replacing `<code></code>` with `{@code }` and `<pre></pre>` with `{@snippet }` but I guess that can wait until someone has the inclination and bandwidth to do it... ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19263#discussion_r1606772388
