On Mon, 20 May 2024 20:55:16 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:

>> Please review this change. I converted the `package.html` file to 
>> `package-info.java`, because `javac` cannot recognize `package.html`.
>> I already brought this up [in the mailing 
>> list](https://mail.openjdk.org/pipermail/serviceability-dev/2024-May/055650.html).
>> The conversion was done in-place, only renaming it in git.
>> 
>> I also added a couple of `@since` tags, with only 2 changes I don't want to 
>> split these two fixes into separate PRs.
>> `CREDENTIALS_FILTER_PATTERN` and `SERIAL_FILTER_PATTERN` were first added in 
>> https://bugs.openjdk.org/browse/JDK-8187556
>
> Nizar Benalla has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   fix indentation

LGTM

-------------

Marked as reviewed by rriggs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19263#pullrequestreview-2071636919

Reply via email to