On Mon, 19 Feb 2024 17:16:34 GMT, Suchismith Roy <s...@openjdk.org> wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library ibm_16_am.a shared archive
>> file on AIX.
>> Hence we are providing a function which will additionally search for .a file
>> on AIX ,when the search for .so file fails.
>
> Suchismith Roy has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - remove error_code
> - revert error code check
src/hotspot/os/aix/os_aix.cpp line 1185:
> 1183: // Shared object in .so format dont have braces, hence they get
> removed for archives with members.
> 1184: if (result == nullptr) {
> 1185: assert(strlen(new_extension) < strlen(old_extension),"New extension
> length must be less than existing one");
`<=` would be sufficient. Please add a whitespace after `,`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1495478067
