On Tue, 27 Feb 2024 07:48:00 GMT, Suchismith Roy <s...@openjdk.org> wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library ibm_16_am.a shared archive
>> file on AIX.
>> Hence we are providing a function which will additionally search for .a file
>> on AIX ,when the search for .so file fails.
>
> Suchismith Roy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove redundant logic
src/hotspot/os/aix/os_aix.cpp line 1176:
> 1174: if (result == nullptr && pointer_to_dot != nullptr &&
> strcmp(pointer_to_dot, old_extension) == 0) {
> 1175: snprintf(pointer_to_dot, sizeof(old_extension), "%s",
> new_extension);
> 1176: result = dll_load_library(file_path, ebuf, ebuflen);
You should have adapted the indentation, too.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1503817600
