On Mon, 19 Feb 2024 10:15:59 GMT, Martin Doerr <mdo...@openjdk.org> wrote:
>> Suchismith Roy has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> src/hotspot/os/aix/os_aix.cpp line 1185:
>
>> 1183: // Shared object in .so format dont have braces, hence they get
>> removed for archives with members.
>> 1184: if (error_code == EACCES || error_code == ENOENT) {
>> 1185: if (strlen(new_extension) > strlen(old_extension)){
>
> I think this should better be an assertion because the extensions are
> constants.
As assertions are not supported in debug builds i did not use assert. May i
know what is the purpose of assert,in general, as per design ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1494392043
