On Mon, 27 Nov 2023 01:56:01 GMT, David Holmes <dhol...@openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Split test and use othervm
>
> test/hotspot/jtreg/runtime/Monitor/libMonitorWithDeadObjectTest.c line 161:
> 
>> 159: 
>> 160:     if (pthread_attr_init(&attr) != 0) die("pthread_attr_init");
>> 161:     if (pthread_create(&attacher, &attr, 
>> create_monitor_with_dead_object_in_thread, NULL) != 0) die("pthread_create");
> 
> You are not actually using the attr object to change anything. On AIX you may 
> need to explicitly set the stack size.

OK. I copied this CommpleteExit.c. Should that be changed as well?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16783#discussion_r1405883743

Reply via email to