On Mon, 27 Nov 2023 01:52:29 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Stefan Karlsson has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Split test and use othervm > > test/hotspot/jtreg/runtime/Monitor/libMonitorWithDeadObjectTest.c line 47: > >> 45: >> 46: #define check(env, what, msg) \ >> 47: check_exception((env), (msg)); \ > > I'm not understanding why you have `check` and `check_exception` here nor why > you choose to use one versus the other. ?? Some JNI calls return something, for those I can use `check` which combines a null-check and an exception check. Some tests don't return anything, they can't null-check and can only perform an exception check. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16783#discussion_r1405874373
