On Sun, 29 Oct 2023 08:07:55 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> I still approve of this patch as it's better than what we had before. There >> are a lot of suggested improvements that can be done either in this PR or in >> a future RFE. `git blame` shows that this hasn't been touched since 2008, so >> I don't think applying all suggestions now is in any sense critical :-). > >> I still approve of this patch as it's better than what we had before. There >> are a lot of suggested improvements that can be done either in this PR or in >> a future RFE. `git blame` shows that this hasn't been touched since 2008, so >> I don't think applying all suggestions now is in any sense critical :-). > > Not touched since 2008 suggests to me there might not be a rush to make the > change as proposed, and instead take > the (I think small) additional time to do the better thing, e.g. the > unary-predicate suggestion made by several folks. Dear @kimbarrett , @dholmes-ora , @stefank, @rose00 , @jdksjolen, @sspitsyn, @merykitty, Thank you all. The final code is now cleaner and nicer. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15418#issuecomment-1824962932
