On Tue, 26 Sep 2023 21:05:22 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Afshin Zafari has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - Merge branch 'master' into _8314502
>> - changed the `E` param of find methods to `const E&`.
>> - find_from_end and its caller are also updated.
>> - 8314502: Change the comparator taking version of GrowableArray::find to
>> be a template method
>> - 8314502: GrowableArray: Make find with comparator take template
>
> src/hotspot/share/gc/parallel/mutableNUMASpace.hpp line 1:
>
>> 1: /*
>
> This seems an unrelated change.
This change came after fixing a merge conflict.
In `mutableNUMASpace.cpp`, at lines 163, 182, 202 and 586 the `find` function
is called in this way:
int i = lgrp_spaces()->find(&lgrp_id, LGRPSpace::equals);
where `lgrp_id` is `int`. Therefore, the `LGRPSpace::equals` has to take an
`int*` in its first argument. The definition of `find` is:
int find(T* token, bool f(T*, const E&)) const {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15418#discussion_r1338278635
