On Tue, 24 Oct 2023 11:51:45 GMT, Johan Sjölen <jsjo...@openjdk.org> wrote:
>> I think that NMT is deserving of its own subdirectory. Can we do a review of >> the changes before I fix the merge conflicts? >> >> 1. Moved all the nmt source code from services/ to nmt/ >> 2. Renamed all the include statements and sorted them >> 3. Fixed the include guards > > Johan Sjölen has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains eight commits: > > - Merge remote-tracking branch 'upstream/master' into move-nmt > - Fix stefank suggestions > - Merge remote-tracking branch 'origin/master' into move-nmt > - Fix messed up include > - Missed this include > - Merge remote-tracking branch 'origin/master' into move-nmt > - Fixed reviewed changes > - Move NMT to its own subdirectory Thanks Stefan, good catch on the ordering requirements. I'll integrate this ASAP. ------------- PR Comment: https://git.openjdk.org/jdk/pull/16276#issuecomment-1780775333
