On Mon, 23 Oct 2023 08:34:59 GMT, Johan Sjölen <jsjo...@openjdk.org> wrote:
>> I think that NMT is deserving of its own subdirectory. Can we do a review of >> the changes before I fix the merge conflicts? >> >> 1. Moved all the nmt source code from services/ to nmt/ >> 2. Renamed all the include statements and sorted them >> 3. Fixed the include guards > > Johan Sjölen has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains six commits: > > - Merge remote-tracking branch 'origin/master' into move-nmt > - Fix messed up include > - Missed this include > - Merge remote-tracking branch 'origin/master' into move-nmt > - Fixed reviewed changes > - Move NMT to its own subdirectory Changes requested by stefank (Reviewer). src/hotspot/share/services/mallocLimit.cpp line 32: > 30: #include "runtime/globals.hpp" > 31: #include "services/mallocLimit.hpp" > 32: #include "nmt/nmtCommon.hpp" Sort order test/hotspot/gtest/nmt/test_nmt_cornercases.cpp line 30: > 28: #include "nmt/mallocTracker.hpp" > 29: #include "runtime/os.hpp" > 30: #include "nmt/memTracker.hpp" Sort order ------------- PR Review: https://git.openjdk.org/jdk/pull/16276#pullrequestreview-1692002562 PR Review Comment: https://git.openjdk.org/jdk/pull/16276#discussion_r1368319264 PR Review Comment: https://git.openjdk.org/jdk/pull/16276#discussion_r1368318877
