On Mon, 23 Oct 2023 08:23:44 GMT, Stefan Karlsson <stef...@openjdk.org> wrote:
>> Johan Sjölen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix messed up include > > src/hotspot/share/nmt/nmtPreInit.hpp line 35: > >> 33: #include "utilities/macros.hpp" >> 34: >> 35: #ifdef ASSERT > > The blank line at 34 is not following the style for our conditional includes. > Remove it, or better yet skip conventionalize the include of > runtime/atomic.hpp since it just adds to noise to the file. Removed the blank line, I think the noise is meaningful in this case. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16276#discussion_r1369924184
