On Tue, 10 Oct 2023 00:21:27 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: removed unneeded comment > > src/hotspot/share/prims/jvmtiExport.cpp line 1614: > >> 1612: >> 1613: // Do not post virtual thread end event for hidden java thread. >> 1614: if (state->is_enabled(JVMTI_EVENT_VIRTUAL_THREAD_END) && > > Should this be assert like in vthread_start? Thanks. Yes, this has to be the same as for `VirtualThreadStart`. Fixed now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16019#discussion_r1351070324