On Fri, 6 Oct 2023 22:59:56 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: convert check for is_hidden_from_external_view check() into assert > > src/hotspot/share/prims/jvmtiExport.cpp line 1581: > >> 1579: assert(!thread->is_hidden_from_external_view(), "carrier threads >> can't be hidden"); >> 1580: >> 1581: // Do not post virtual thread start event for hidden java thread. > > Why would we ever have a hidden virtual thread? Also, why is this comment > here. It is also below, which seems to be the more appropriate location. Good catch, thanks. Forgot to remove this comment. Fixed now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16019#discussion_r1351004505
