On Fri, 6 Oct 2023 23:03:14 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: convert check for is_hidden_from_external_view check() into assert > > src/hotspot/share/prims/jvmti.xml line 13044: > >> 13042: >> 13043: <event label="Virtual Thread Start" >> 13044: id="VirtualThreadStart" >> const="JVMTI_EVENT_VIRTUAL_THREAD_START" num="87" phase="start" since="21"> > > Does "filtered" mean that the event can be enabled or disabled on a per > thread basis, and therefore by removing this it means the event can only be > enabled or disabled globally? That's right. The spec for SetEventNotificationMode lists the events cannot be enabled/disabled at the thread level. Both ThreadStart and VirtualThreadStart are listed so I view this JBS/PR issue as fixing the implementation. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16019#discussion_r1349472883
