On Fri, 8 Sep 2023 23:28:01 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:

>> Would it makes sense also to check that thread state is TIMED_WAITING. It 
>> should be set  TIMED_WAITING unmounted threads 
>> https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/lang/Thread.State.html#TIMED_WAITING
>
> It is strange that the the tested vthreads in sleep(timeout) have sate 
> WAITING, not TIMED_WAITING.
> It can be a bug in the implementation.
> I've decided to add a short sleep. Checking states looks a little bit over 
> complicated.

Could you please also add comment with sleep which describe why is it needed 
and mention that the insufficient sleep time couldn't cause test failures. Test 
should pass anyway just don't test expected state.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15467#discussion_r1320620378

Reply via email to