On Wed, 6 Sep 2023 20:23:57 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commits since the last revision: >> >> - Merge >> - 8312174: missing JVMTI events from vthreads parked during JVMTI attach > > test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadEventTest/VThreadEventTest.java > line 100: > >> 98: mready.await(); >> 99: try { >> 100: // timeout is big enough to keep mounted untill >> interrupted > > The comment is misleading. 1st group of threads are expected to be unmounted > during attach and mounted after the threads are interrupted. Thanks! It was original typo in the comment. Fixed now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15467#discussion_r1319870711