On Wed, 6 Sep 2023 20:24:59 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commits since the last revision:
>>
>> - Merge
>> - 8312174: missing JVMTI events from vthreads parked during JVMTI attach
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadEventTest/VThreadEventTest.java
> line 91:
>
>> 89:
>> 90: try (ExecutorService executorService =
>> Executors.newVirtualThreadPerTaskExecutor()) {
>> 91: for (int tCnt = 0; tCnt < TCNT1; tCnt++) {
>
> Could you please add a comment before each test group creation block about
> expected state
Good suggestion. Fixed now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15467#discussion_r1319886373
