On Tue, 6 Jun 2023 23:39:54 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: call get_thread_state_base only when needed > > src/hotspot/share/prims/jvmtiEnvBase.hpp line 386: > >> 384: >> 385: // get platform thread state >> 386: static jint get_thread_state_base(oop thread_oop, JavaThread* jt); > > maybe rename it to `get_platform_thread_state`? I was thinking about it. It will be inconsistent with`get_vthread_state`. Ideally, then the `get_vthread_state` needs to be replaced with the `get_virtual_thread_state`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14298#discussion_r1220559583
