On Mon, 5 Jun 2023 19:00:49 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> When a virtual thread is mounted, the carrier thread should be reported as >> "waiting" until the virtual thread unmounts. Right now, GetThreadState >> reports a state based the JavaThread status when it should return >> JVMTI_THREAD_STATE_WAITING | JVMTI_THREAD_STATE_WAITING_INDEFINITELY. >> The fix adds: >> - a special case for passive carrier threads >> - necessary test coverage to the existing JVMTI test: >> `serviceability/jvmti/vthread/ThreadStateTest`. >> >> Testing: >> - tested with the updated test: >> `serviceability/jvmti/vthread/ThreadStateTest` >> - submitted mach5 tiers 1-5 >> - TBD: to submit mach5 tier 6 > > Serguei Spitsyn has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - Merge > - minor tweaks in libThreadStateTest.cpp > - 8307153: JVMTI GetThreadState on carrier should return STATE_WAITING Without the fix in place, do your new tests reproduce the issue> I'm trying to recall the origins of the filing of this CR. I thought I had noticed this issue while working with a JDI test and discussed it with you and Alan. Just wondering if there is something that can be done to a JDI test to also test for this. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14298#issuecomment-1577432927
