On Wed, 7 Jun 2023 13:24:32 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: one function renaming > > src/hotspot/share/prims/jvmtiEnvBase.cpp line 1741: > >> 1739: "sanity check"); >> 1740: >> 1741: // An attempt to handshake-suspend a passive carrier thread will >> result in > > The rename from is_passive_carrier_thread to is_thread_carrying_vthread > looks fine. There are a few stray comments that still say "passive carrier > thread" that probably should be cleaned up. I see you've just integrated this > change but maybe the next change in the area that do this. Thanks. Alan. Will do this cleanup when there is a chance. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14298#discussion_r1221612240
