On Thu, 27 Apr 2023 10:58:14 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> install_async_exception: set interrupt status for platform threads only > > src/hotspot/share/prims/jvmti.xml line 11984: > >> 11982: <errorid id="JVMTI_ERROR_OPAQUE_FRAME" num="32"> >> 11983: Information about the frame is not available (e.g. for native >> frames), >> 11984: or the frame is not suitable for the requested operation. > > After re-reading the spec changes, I'm wondering if we can improve on "or the > frame is not suitable for the requested operation". StopThread doesn't have > a frame parameter. ForceEarlyReturn doesn't have a frame parameter either as > it's implicit (the current frame). I wonder if wording something like this > might be better: > "or a function on a thread cannot be performed at the thread's current frame". The wording starts off with "Information about the frame...", and you haven't suggested to change that to "the current frame". We should be consistent. Can't we just change both "the frame" references to "the current frame", and leave the rest the same as what Serguei has in place here? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13546#discussion_r1179561498
