On Fri, 21 Apr 2023 16:34:34 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> corrections for BoundVirtualThread and test typos
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTest/StopThreadTest.java
> line 89:
>
>> 87: log("\nMain #A: method A() must be blocked on entering a
>> synchronized statement");
>> 88: synchronized (TestTask.lock) {
>> 89: testTaskThread =
>> Thread.ofVirtual().name("TestTaskThread").start(testTask);
>
> Do we have other tests that are doing the equivalent testing on platform
> threads?
Do you ask this question to check if we want to extend this test to provide
coverage for platform threads as well?
The support of platform threads is much simpler. The JVMTI `StopThread` never
returns the `THREAD_NOT_SUSPENDED` and `OPAQUE_FRAME` error codes for platform
threads. So that this kind of testing is not needed for platform threads.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13546#discussion_r1174068855
