On Sat, 22 Apr 2023 00:09:27 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> For the JDI tests I added, I execute them in both modes, with the >> appropriate adjustments to account for the errors we except for virtual >> threads. We should be testing to make sure that StopThread works with >> platform threads under a variety of situations. > > Extending this test to cover platform threads does not look natural and is > going to be a little ugly. > But I can extend it to provide coverage for BoundVirtualThread case > which is highjacking the platform thread implementation. > Would it help? > We should have pretty good coverage of the JVMTI `StopThread` for platform > threads in `nsk.jvmti` test suite. > It includes: > - `stopthrd006` and `stopthrd007` > - a number of `scenarios/capability/CM01 `tests > > Also, this extension does not touch the code path of platform threads support. I've extended the test to cover platform threads as well. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13546#discussion_r1175995443
