On Tue, 17 Jan 2023 08:35:45 GMT, Fredrik Bredberg <d...@openjdk.org> wrote:
>> Implementation of relativized locals in interpreter frames for x86. x64, >> arm, aarch64, ppc64le and riscv. >> Not relativized locals on zero and s390 but done some changes to cope with >> the changed generic code. >> Tested tier1-tier8 on supported platforms. The rest was sanity tested using >> Qemu, except s390, which was only tested by GitHub Actions. > > Fredrik Bredberg has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains five additional > commits since the last revision: > > - Merge branch 'master' into relativize-locals-JDK-8299795_2023-01-09 > - Added references to JDK-8300197 > - Updated some copyright dates. > - Changed copyright date to 2023 > - 8299795: Relativize locals in interpreter frames src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp line 1035: > 1033: __ sub(R12_scratch2, R18_locals, R1_SP); > 1034: __ srdi(R12_scratch2, R12_scratch2, Interpreter::logStackElementSize); > 1035: // Now &fp()[R12_scratch2] == R18_locals I think this comment makes no sense. Please remove it. Otherwise, PPC64 code LGTM. ------------- PR: https://git.openjdk.org/jdk/pull/11902
