On Wed, 18 Jan 2023 15:46:22 GMT, Fredrik Bredberg <d...@openjdk.org> wrote:
>> The code uses &sp()[R12_scratch2]. I think your comment is confusing. Please >> remove it or write something comprehensive. E.g. save R18_locals in >> compressed format relative to the new top frame's FP (= current SP). > > See what you mean, the R1_SP being the frame pointer is confusing. So how > about changing the comment into: > "// Store relativized R18_locals, see frame::interpreter_frame_locals()." > Would that work for you? If not I'll just remove it. That's fine. Thanks! ------------- PR: https://git.openjdk.org/jdk/pull/11902