On Wed, 11 Jan 2023 09:22:03 GMT, Fredrik Bredberg <d...@openjdk.org> wrote:
>> Implementation of relativized locals in interpreter frames for x86. x64,
>> arm, aarch64, ppc64le and riscv.
>> Not relativized locals on zero and s390 but done some changes to cope with
>> the changed generic code.
>> Tested tier1-tier8 on supported platforms. The rest was sanity tested using
>> Qemu, except s390, which was only tested by GitHub Actions.
>
> Fredrik Bredberg has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Updated some copyright dates.
This looks great. Very nice work!
src/hotspot/cpu/aarch64/continuationFreezeThaw_aarch64.inline.hpp line 306:
> 304: // set relativized locals
> 305: // this line can be changed into an assert when we have fixed the
> "frame padding problem"
> 306: *f.addr_at(frame::interpreter_frame_locals_offset) = (bottom - 1) -
> f.fp();
Thank you for this comment. When you file the CR for this problem, can you
point to this CR?
src/hotspot/cpu/ppc/continuationFreezeThaw_ppc.inline.hpp line 554:
> 552: inline void ThawBase::set_interpreter_frame_bottom(const frame& f,
> intptr_t* bottom) {
> 553: // set relativized locals
> 554: // this line can be changed into an assert when we have fixed the
> "frame padding problem"
Can you file an RFE (or is there already one) to describe this?
-------------
Marked as reviewed by coleenp (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11902
