On Wed, 19 Oct 2022 22:58:32 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/share/jni/jni_tools.h line 136: >> >>> 134: * Declared and defined in jvmti_common.h >>> 135: */ >>> 136: //char *jlong_to_string(jlong value, char *string); >> >> It seems odd to have jlong_to_string and julong_to_string implemented in >> different places. Maybe more cleanup is needed here. > > I'd suggest to move julong_to_string to the same place where the > jlong_to_string is placed and remove all these with the comments from > jni_tools. > I agree, we may need to file a separate bug for global cleanup which should > get rid of JVMTITools.*. I moved julong_to_string (and define for julong type) to jvmti_common.h About JVMTITools.* JVMTITools.cpp is included in 628 tests, JVMTITools.h is included in 348 files. I don't think removing this 2 files worth such massive change ------------- PR: https://git.openjdk.org/jdk/pull/10733
