On Mon, 17 Oct 2022 19:22:26 GMT, Alex Menkov <amen...@openjdk.org> wrote:
> Failures of the test are usually caused by unexpected frame in the stack. > Also the failures are intermittent, so it makes sense to report more details > on error to simplify analysis. > The fix adds stack trace printing if the test fails Thank you for review. It was supposed to be a small local fix, but I agree with the point about code duplication. We have 2 places with shared code for JVMTI tests: test/lib/jdk/test/lib/jvmti/jvmti_common.h and test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/ jvmti_common.h contains both declaration and definitions, NSK shared files have separate .h and .cpp files (.cpp files are included in test .cpp files) This 2 "libraries" have some duplicate functions and cannot be used simultaneously (a number of compiler errors). I'm trying to resolve this without massive code change. The plan is to include jvmti_common.h in some nsk shared files and remove duplicated functions from nsk files. @lmesnik what do you think about the approach? ------------- PR: https://git.openjdk.org/jdk/pull/10733
