On Wed, 19 Oct 2022 00:04:43 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> Failures of the test are usually caused by unexpected frame in the stack. >> Also the failures are intermittent, so it makes sense to report more details >> on error to simplify analysis. >> The fix adds stack trace printing if the test fails > > Alex Menkov has updated the pull request incrementally with one additional > commit since the last revision: > > merged serviceability/jvmti and nsk/share/jvmti shared code I think the cleanup is disruptive enough that it should be a separate PR. Probably the easiest approach is to file a new CR for the cleanup and repurpose this PR for it, which means also moving the popframe004.cpp changes to a new PR. test/hotspot/jtreg/vmTestbase/nsk/share/jni/jni_tools.h line 136: > 134: * Declared and defined in jvmti_common.h > 135: */ > 136: //char *jlong_to_string(jlong value, char *string); It seems odd to have jlong_to_string and julong_to_string implemented in different places. Maybe more cleanup is needed here. ------------- PR: https://git.openjdk.org/jdk/pull/10733
