On Thu, 10 Sep 2026 08:52:51 GMT, Andreas Chmielewski 
<[email protected]> wrote:

>> I want to propose this enhancement. Please see the CSR.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Andreas Chmielewski has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Add TLS 1.2 EMS algorithm alias in SunJCE

src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsExtendedMasterSecretGenerator.java
 line 43:

> 41:  * @since x.x
> 42:  */
> 43: public final class P11TlsExtendedMasterSecretGenerator extends 
> KeyGeneratorSpi {

nit: since this is TLS1.2 only, consider renaming this to 
`P11Tls12ExtendedMasterSecretGenerator`?

src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java line 
1035:

> 1033:                 "sun.security.pkcs11.P11TlsMasterSecretGenerator",
> 1034:             m(CKM_TLS12_MASTER_KEY_DERIVE, 
> CKM_TLS12_MASTER_KEY_DERIVE_DH));
> 1035:         d(KG, "SunTlsExtendedMasterSecret",

Change this to `SunTls12ExtendedMasterSecret`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32081#discussion_r3982181184
PR Review Comment: https://git.openjdk.org/jdk/pull/32081#discussion_r3982172449

Reply via email to