On Thu, 10 Sep 2026 18:18:48 GMT, Valerie Peng <[email protected]> wrote:
>> Andreas Chmielewski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add TLS 1.2 EMS algorithm alias in SunJCE
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsExtendedMasterSecretGenerator.java
> line 43:
>
>> 41: * @since x.x
>> 42: */
>> 43: public final class P11TlsExtendedMasterSecretGenerator extends
>> KeyGeneratorSpi {
>
> nit: since this is TLS1.2 only, consider renaming this to
> `P11Tls12ExtendedMasterSecretGenerator`?
done
> src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_keymgmt.c line 957:
>
>> 955:
>> 956: tls12CopyBackClientVersion(env, ckpMechanism, jMechanism,
>> 957: p->pVersion,
>> CLASS_TLS12_EXTENDED_MASTER_KEY_DERIVE_PARAMS);
>
> `tls12CopyBackClientVersion(...)` is essentially `copyBackClientVersion(...)`
> after this change, maybe just call `copyBackClientVersion(...)` directly and
> get rid of `tls12CopyBackClientVersion(...)`? I find this easier to
> read/understand since the new `tls12CopyBackClientVersion(...)` does not do
> any TLS1.2 specific handling beside calling `copyBackClientVersion(...)`.
good point :)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32081#discussion_r3989465675
PR Review Comment: https://git.openjdk.org/jdk/pull/32081#discussion_r3989454833
