On Thu, 10 Sep 2026 08:52:51 GMT, Andreas Chmielewski 
<[email protected]> wrote:

>> I want to propose this enhancement. Please see the CSR.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Andreas Chmielewski has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Add TLS 1.2 EMS algorithm alias in SunJCE

src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_keymgmt.c line 957:

> 955: 
> 956:         tls12CopyBackClientVersion(env, ckpMechanism, jMechanism,
> 957:                 p->pVersion, 
> CLASS_TLS12_EXTENDED_MASTER_KEY_DERIVE_PARAMS);

`tls12CopyBackClientVersion(...)` is essentially `copyBackClientVersion(...)` 
after this change, maybe just call `copyBackClientVersion(...)` directly and 
get rid of `tls12CopyBackClientVersion(...)`? I find this easier to 
read/understand since the new `tls12CopyBackClientVersion(...)` does not do any 
TLS1.2 specific handling beside calling `copyBackClientVersion(...)`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32081#discussion_r3983382316

Reply via email to