On Wed, 27 May 2026 12:35:04 GMT, Andrew Dinn <[email protected]> wrote:
> I'm not reviewing the actual multiply generator algorithm but the rest of the > stub declaration and setup looks good. Thank you. > I have 2 questions: > > 1. How has this been tested? Curve25519 related test suites have been ran against these changes, both on Windows and Linux: test/jdk/sun/security/util/math/TestIntegerModuloP.java#IntegerPolynomial25519 test/jdk/sun/security/ec/xec/TestXDH.java test/jdk/sun/security/ec/xec/TestXECOps.java test/jdk/sun/security/ec/xec/XECIterative.java test/jdk/sun/security/ec/xec/XECKeyFormat.java test/jdk/sun/security/ec/ed/EdCRLSign.java test/jdk/sun/security/ec/ed/EdDSAParamSpec.java test/jdk/sun/security/ec/ed/TestEdDSA.java > 2. Is someone working on an AArch64 implementation? Yes, I've completed the implementation last night but won't publish the PR because of the dependencies that it has on this PR. I'll provide differences between the two implementations as far as algorithms employed and performance results. ------------- PR Comment: https://git.openjdk.org/jdk/pull/31087#issuecomment-4559212481
